Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(withdrawal_unlocker): rejected unlock tx isn't removed #682

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented May 9, 2022

  • fix get_transaction_status throw invalid type: null, expected struct TransactionView error for rejected tx, return Ok(None) instead.
  • always drop unlock tx and retry if get_transaction_status return error, avoid "lock" withdrawal cell.

@jjyr jjyr requested review from Flouse and blckngm May 9, 2022 06:41
@blckngm
Copy link
Contributor

blckngm commented May 9, 2022

fix get_transaction_status throw invalid type: null, expected struct TransactionView error for rejected tx, return Ok(None) instead.

It seems that this could be fixed by updating ckb-jsonrpc-types too: https://docs.rs/ckb-jsonrpc-types/latest/ckb_jsonrpc_types/struct.TransactionWithStatus.html

@jjyr jjyr merged commit b72c74b into godwokenrises:develop May 9, 2022
@jjyr
Copy link
Collaborator

jjyr commented May 9, 2022

fix get_transaction_status throw invalid type: null, expected struct TransactionView error for rejected tx, return Ok(None) instead.

It seems that this could be fixed by updating ckb-jsonrpc-types too: https://docs.rs/ckb-jsonrpc-types/latest/ckb_jsonrpc_types/struct.TransactionWithStatus.html

Correct, we should also upgrade ckb_sdk to new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants