Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of only package success transactions caused some problems:
the nonce becomes inconsistent once user send a failed transaction.
So this PR introduce a backward compatible way to fix this. When a transaction is failed(return a non-zero exit code), the written state of the transaction is reverted, the sender's nonce is increased by 1, and the transaction fee is paid to block-producer. For
PolyjuiceTx
thegas_used * gas_price
amount of CKB is charged. For other transaction, theargs.fee
is charged.