Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generator): exceeded MAX_WRITE_DATA_BYTES_LIMIT error #685

Merged
merged 2 commits into from
May 10, 2022
Merged

fix(generator): exceeded MAX_WRITE_DATA_BYTES_LIMIT error #685

merged 2 commits into from
May 10, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented May 10, 2022

  • compare MAX_WRITE_DATA_BYTES_LIMIT with each data size instead of total write data size.
  • align MAX_WRITE_DATA_BYTES_LIMIT to 25 * 1024, same as GW_MAX_DATA_SIZE in godwoken-scripts.

@Flouse Flouse requested review from jjyr and RetricSu May 10, 2022 03:35
@RetricSu RetricSu mentioned this pull request May 10, 2022
Closed
@Flouse Flouse merged commit 7684dd4 into godwokenrises:develop May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr approved these changes

@keroro520 keroro520 keroro520 approved these changes

@RetricSu RetricSu RetricSu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeroqn @Flouse @jjyr @keroro520 @RetricSu