Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mempool): pending withdrawals not in mem block aren't restored #687

Merged
merged 2 commits into from
May 13, 2022
Merged

fix(mempool): pending withdrawals not in mem block aren't restored #687

merged 2 commits into from
May 13, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented May 10, 2022

  • restore pending withdrawals from db

jjyr
jjyr previously approved these changes May 11, 2022
View reviewed changes
@jjyr jjyr requested a review from Flouse May 11, 2022 10:26
@Flouse
Copy link
Collaborator

Flouse commented May 12, 2022

What is the plan of TODO: Check replace-by-fee in fn push_withdrawal_request?
@jjyr

@Flouse Flouse requested review from magicalne and blckngm May 12, 2022 10:25
@jjyr
Copy link
Collaborator

jjyr commented May 13, 2022 •
edited
Loading

What is the plan of TODO: Check replace-by-fee in fn push_withdrawal_request? @jjyr

We should implement a similar mechanism like TxFeeQueue for the withdrawal

@jjyr jjyr merged commit 1c6adec into godwokenrises:develop May 13, 2022
@zeroqn zeroqn deleted the fix-mempool-pending-withdrawals-not-in-mem-block-arnt-restored branch July 13, 2022 02:51
@zeroqn zeroqn restored the fix-mempool-pending-withdrawals-not-in-mem-block-arnt-restored branch July 13, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr left review comments

@magicalne magicalne Awaiting requested review from magicalne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroqn @Flouse @jjyr @blckngm