Fix: Improve the withdrawal packaging performance #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jjyr
commented
May 24, 2022
•
jjyr
commented
- Fix a bug of withdrawal packaging. Before the fix, Godwoken skip packaging withdrawals every two blocks. Now, it packages withdrawals in every block.
- Increase maximum deposits & withdraws of each block from 50 to 100(100 depostis + 100 withdrawals costs ~ 240_000_000 cycles).
- Increase the maximum cycles of layer1 submission transaction to 350_000_000 (1/10 of a CKB block).
- Improve the logging of block-produce
blckngm
reviewed
May 24, 2022
keroro520
reviewed
May 24, 2022
|
ACK the three items:
I do not quite understand how bug 6596222 can be triggered. Can this bugfix be moved to another PR? |
Updated the test case. |
blckngm
previously approved these changes
May 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
keroro520
previously approved these changes
May 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jjyr
force-pushed
the
logging-produce-block-time
branch
from
72aac35 to
1691df5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jjyr
force-pushed
the
logging-produce-block-time
branch
from
1691df5 to
f9896af
Compare
|
/itest |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
blckngm
reviewed
May 26, 2022
zeroqn
previously approved these changes
May 26, 2022
blckngm
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.