fix: don't set TCP keepalive on listening sockets #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Mac OS X, it causes the listening socket to be “closed” after the keepalive timeout and future connections to fail with “connection refused” errors. We suspect the same may happen on linux in some circumstances because we see similar errors in CI. For hyper, we switch to use `AddrIncoming::set_keepalive`. It sets TCP keepalive options on sockets returned by `accept` instead of on the listening socket. Tentacle unfortunately does not seem to allow setting options on accepted sockets, so TCP keepalive setting is removed for now.
Running integration testWorkflow Run Id: 2407767058 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
zeroqn
approved these changes
May 30, 2022
keroro520
reviewed
May 30, 2022
| // Start a hyper server. | ||
| let server = Server::builder(AddrIncoming::from_listener(listener)?) |
There was a problem hiding this comment.
/// Creates a new `AddrIncoming` from an existing `tokio::net::TcpListener`.
pub fn from_listener(listener: TcpListener) -> crate::Result<Self> {
let addr = listener.local_addr().map_err(crate::Error::new_listen)?;
Ok(AddrIncoming {
listener,
addr,
sleep_on_errors: true,
tcp_keepalive_timeout: None,
tcp_nodelay: false,
timeout: None,
})
}curious why hyper doesn't inherit the keepalive options from socket
keroro520
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OS X, it causes the listening socket to be “closed” after the
keepalive timeout and future connections to fail with “connection
refused” errors. We suspect the same may happen on linux in some
circumstances because we see similar errors in CI.
For hyper, we switch to use
AddrIncoming::set_keepalive. It sets TCPkeepalive options on sockets returned by
acceptinstead of on thelistening socket.
Tentacle unfortunately does not seem to allow setting options on
accepted sockets, so TCP keepalive setting is removed for now.