feat(config): move packaging params from constant to config #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jjyr
reviewed
Jun 2, 2022
crates/config/src/config.rs
Outdated
| pub struct MemBlockConfig { | ||
| pub max_deposit: usize, | ||
| pub max_withdrawal: usize, | ||
| pub max_tx: usize, |
There was a problem hiding this comment.
- max_deposits
- max_withdrawals
- max_txs
jjyr
reviewed
Jun 2, 2022
crates/config/src/config.rs
Outdated
| Self { | ||
| max_deposit: 100, | ||
| max_withdrawal: 100, | ||
| max_tx: 1500, |
There was a problem hiding this comment.
max_txs -> 1000
1500 may causes repackage of a block
Running integration testWorkflow Run Id: 2426712977 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
zeroqn
approved these changes
Jun 2, 2022
jjyr
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.