fix: refresh readonly mem-pool when receives new mem-block #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckngm
reviewed
Jun 8, 2022
blckngm
reviewed
Jun 8, 2022
This comment was marked as outdated.
This comment was marked as outdated.
blckngm
reviewed
Jun 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
jjyr
force-pushed
the
fix-refresh-readonly-mem-pool-when-receives-mem-block
branch
from
51efa81
to
cbf9ede
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
blckngm
previously approved these changes
Jun 13, 2022
Running integration testWorkflow Run Id: 2486855470 Components:
Manually running integration testPost a comment contains Note: Run Resultfailure Run Resultfailure |
zeroqn
previously approved these changes
Jun 13, 2022
|
/itest |
Running integration testWorkflow Run Id: 2487384420 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
|
/itest |
Running integration testWorkflow Run Id: 2487571599 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
Flouse
previously approved these changes
Jun 13, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
jjyr
force-pushed
the
fix-refresh-readonly-mem-pool-when-receives-mem-block
branch
from
cbf9ede
to
416a971
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/itest |
Running integration testWorkflow Run Id: 2488391108 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
Flouse
approved these changes
Jun 13, 2022
Flouse
added a commit
to Flouse/godwoken-docker-prebuilds
that referenced
this pull request
Jun 14, 2022
blckngm
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Readonly node should not do it's own computation when the mem-pool reset, instead, the node should always wait for the full node to publish a new mem-block state, and then to sync with that state.
In this PR:
MemPool#resetfunction.Note: The web3-indexer should subscribe the readonly node API to keep consistent state.