Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-server): get in queue requests #726

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Jun 14, 2022

Now on a full node the gw_get_transaction/gw_get_withdrawal RPC
calls will return status: pending instead of null for in queue
transactions/withdrawals.

Also added RPC method gw_is_request_in_queue, which returns whether a
transaction or withdrawal is in queue.

@gw-bot
Copy link

gw-bot bot commented Jun 14, 2022

Running integration test

Workflow Run Id: 2493666217

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@jjyr
Copy link
Collaborator

jjyr commented Jun 15, 2022

Only full node has fee queue, readonly node can skip query from the map, can we pass InQueueRequestMap as a Option<T> args to functions.

@gw-bot
Copy link

gw-bot bot commented Jun 15, 2022

Running integration test

Workflow Run Id: 2499679966

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@blckngm blckngm requested a review from jjyr June 22, 2022 02:33
Now on a full node the `gw_get_transaction`/`gw_get_withdrawal` RPC
calls will return status: pending instead of null for in queue
transactions/withdrawals.

Also added RPC method `gw_is_request_in_queue`, which returns whether a
transaction or withdrawal is in queue.
@gw-bot
Copy link

gw-bot bot commented Jun 22, 2022

Running integration test

Workflow Run Id: 2539491130

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@jjyr jjyr requested a review from zeroqn June 29, 2022 07:19
@jjyr jjyr merged commit 91d3a53 into develop Jun 30, 2022
@jjyr jjyr deleted the get-in-queue-transactions branch June 30, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants