Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle VM InvalidCycles by generate a polyjuice system log #729

Merged
merged 2 commits into from
Jun 21, 2022
Merged

fix: handle VM InvalidCycles by generate a polyjuice system log #729

merged 2 commits into from
Jun 21, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Jun 15, 2022

  • Handle ckb_vm::error::Error::InvalidCycles error raise form CKB VM
  • Set run_result.exit_code to 1 in that case.
  • Generate a polyjuice system log account: raw_tx.to_id, gas_used: gas, cumulative_gas_used: gas, created_address: [0u8; 20], status: 0,.

@gw-bot
Copy link

gw-bot bot commented Jun 15, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2500670319

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

classicalliu
classicalliu previously approved these changes Jun 15, 2022
View reviewed changes
zeroqn
zeroqn previously approved these changes Jun 15, 2022
View reviewed changes
@Flouse Flouse requested a review from magicalne June 16, 2022 03:48
Flouse
Flouse previously approved these changes Jun 16, 2022
View reviewed changes
@jjyr jjyr dismissed stale reviews from Flouse, zeroqn, and classicalliu via 4d71126 June 16, 2022 04:40
@gw-bot
Copy link

gw-bot bot commented Jun 16, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2506753820

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@Flouse Flouse mentioned this pull request Jun 17, 2022
Closed
@jjyr jjyr merged commit 612aac8 into godwokenrises:develop Jun 21, 2022
@jjyr jjyr deleted the fix-handle-max-cycles-error branch June 21, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@magicalne magicalne magicalne approved these changes

@classicalliu classicalliu classicalliu left review comments

@zeroqn zeroqn zeroqn left review comments

@keroro520 keroro520 Awaiting requested review from keroro520

@blckngm blckngm Awaiting requested review from blckngm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjyr @Flouse @magicalne @classicalliu @zeroqn