Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(block-producer): exit during bad block challenge #755

Merged
merged 6 commits into from
Jul 12, 2022
Merged

fix(block-producer): exit during bad block challenge #755

merged 6 commits into from
Jul 12, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Jul 6, 2022

  • fix: no dump on dry run challenge tx failed
  • fix: invalid code hash for challenger tx (omni lock)
  • fix: chain notify mem pool with bad block tip hash cause mem pool set snapshot assertion failure
  • fix: pool duplicated challenger tx due to replace poa lock with omni lock
  • fix: mem pool isn't reset after bad block is reverted
  • fix: one finalized custodian with no withdrawal

@zeroqn
fix(challenger): no tx dump after dry run failure
b6a87ef
@zeroqn
fix(challenger): invalid code hash for omni lock
6889e46
@zeroqn
fix(chain): notify mem pool with bad block hash
139c315 
If we found a bad block, should notify mem pool with last valid tip
block hash.
@zeroqn
fix(challenger): submit tx failure because PoolRejectedDuplicatedTran…
ffbadd3 
…saction

Track last submit tx status, wait if tx is pending or proposed.
@zeroqn
fix(block-producer): include one finalized custodian with no withdrawal
b54ce69
@zeroqn
fix(chain): mempool isn't reset after bad block is reverted
e0ac5a5 
Should check pending deposits and finalized custodians liveness and
refresh.

Deposit cell may pass cancel timeout and get reclaimed.
Finalized custodian cell may be merged in bad block tx, and this will
not be reverted.
@gw-bot
Copy link

gw-bot bot commented Jul 6, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2622281098

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@Flouse Flouse requested a review from jjyr July 6, 2022 14:22
@jjyr jjyr requested review from keroro520 and blckngm July 8, 2022 04:34
@jjyr jjyr merged commit 7a49607 into godwokenrises:develop Jul 12, 2022
@zeroqn zeroqn deleted the fix-exit-on-bad-block branch July 13, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@jjyr jjyr jjyr approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520

Assignees

@zeroqn zeroqn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroqn @jjyr @blckngm