Add godwoken scripts as sub folder #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: gwos git-subtree-split: 3c98e214eeac38bc44fa0c9e319f2cea1cb11458
Running integration testWorkflow Run Id: 3391314208 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
blckngm
reviewed
Nov 4, 2022
|
|
||
| [dependencies] | ||
| ckb-std = "0.9.0" | ||
| gw-types = { git = "https://github.com/nervosnetwork/godwoken.git", rev = "91c324544424292b4d715ce376d31bc45aa3cb5d", default-features = false } |
There was a problem hiding this comment.
Do we plan to migrate to using path dependencies to reference godwoken crates?
There was a problem hiding this comment.
The contracts are built within a docker container. We can't just reference crates by the path. I am thinking of making a no-std specific version of gw-types and gw-common crates.
Running integration testWorkflow Run Id: 3391718572 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
blckngm
approved these changes
Nov 4, 2022
zeroqn
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add https://github.com/godwokenrises/godwoken-scripts as subtree in
/gwosfolder