Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused crates #844

Merged
merged 8 commits into from
Nov 9, 2022
Merged

chore: remove unused crates #844

merged 8 commits into from
Nov 9, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Nov 7, 2022 •
edited
Loading

  • Remove eoa-mapping and ckb-hardfork.
  • Move gwos/tests into crates/tests/script-tests.

blckngm
blckngm previously approved these changes Nov 7, 2022
View reviewed changes
@jjyr jjyr requested a review from blckngm November 7, 2022 15:38
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 7, 2022
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 7, 2022
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 8, 2022
blckngm
blckngm previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@blckngm blckngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about scripts fetched to .tmp/binaries?

@jjyr
Copy link
Collaborator Author

jjyr commented Nov 8, 2022 •
edited
Loading

What about scripts fetched to .tmp/binaries?

I want to remove the binary fetch script and implement a build & cache mechanism. CI refreshes the cache when /gwos changes, otherwise it downloads script binaries from the cache.

This should be implemented in another PR.

@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 8, 2022
@jjyr jjyr requested a review from blckngm November 8, 2022 06:06
@gw-bot
Copy link

gw-bot bot commented Nov 8, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 3418651997

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 8, 2022
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 8, 2022
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 8, 2022
@jjyr jjyr merged commit 368c2cb into godwokenrises:develop Nov 9, 2022
@jjyr jjyr deleted the remove-unused-crates branch November 9, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroqn zeroqn zeroqn approved these changes

@Flouse Flouse Awaiting requested review from Flouse

@magicalne magicalne Awaiting requested review from magicalne

@classicalliu classicalliu Awaiting requested review from classicalliu

@blckngm blckngm Awaiting requested review from blckngm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyr @blckngm @zeroqn