refactor: move gw-types and gw-common to gwos folder
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
force-pushed
the
renaming-fields
branch
2 times, most recently
from
7d84d1d
to
c7ff6b9
Compare
jjyr
force-pushed
the
renaming-fields
branch
from
c7ff6b9
to
9088f20
Compare
blckngm
reviewed
Dec 13, 2022
jjyr
force-pushed
the
renaming-fields
branch
from
9088f20
to
125386a
Compare
jjyr
force-pushed
the
renaming-fields
branch
from
96a4bf8
to
9f0d992
Compare
What's the purpose of this change? |
jjyr
force-pushed
the
renaming-fields
branch
from
9f0d992
to
cad7bea
Compare
By moving these crates into |
jjyr
force-pushed
the
renaming-fields
branch
from
15957a0
to
dbc8d16
Compare
blckngm
previously approved these changes
Dec 15, 2022
…d_timepoint_to_since
jjyr
force-pushed
the
renaming-fields
branch
from
72506b4
to
7416271
Compare
jjyr
force-pushed
the
renaming-fields
branch
from
fde71ae
to
a4a0ac4
Compare
jjyr
force-pushed
the
renaming-fields
branch
from
a4a0ac4
to
ebba812
Compare
jjyr
force-pushed
the
renaming-fields
branch
from
7571e4d
to
7b444dc
Compare
zeroqn
approved these changes
Dec 19, 2022
blckngm
approved these changes
Dec 19, 2022
Merged
jjyr
added a commit
that referenced
this pull request
Dec 19, 2022
* refactor: move `gw-types` and `gw-common` to `gwos` folder * fix(ci): install nightly rustfmt * fix: prevent to get a early since value in global_state_last_finalized_timepoint_to_since * fix(ci): script-tests c-uint256-tests * refactor: move smt from `gw-common` to a standalone crate `gw-smt` * refactor: remove tron account lock contract * chore: remove unused step from CI * refactor: define H256 as alias of [u8; 32] * refactor: remove unused files from gw-smt * refactor: reduce copy when convert Vec<SMTH256> * fix(ci): fix molecule schema url * fix: fix evm tests * fix: gwos-evm tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gw-typesandgw-commonto thegwosfolder. Then we can directly referent them in the contract by the path.gw-commonto a standalone crategw-smt, so we can simplify the dependency of rust contracts.capsuletoolchain tonightly-2021-08-16gwos/contracts/tron-account-lock. Tron lock is not enabled both in the testnet and mainnet.gw_utils::block_timepointtogw_utils::finalized_timepoint