Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gw-tools)!: enhance several commands #983

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Feb 13, 2023

  • Deploy scripts with chained txs, this is much faster than deploying them one-by-one.

  • Don't use ckb-cli. It often has breaking changes. Just use our TransactionSkeleton and Wallet. I have also added various helper functions to make this easier.

  • Enhance generate-config so that kicker doesn't need to modify or read generated config files with sed/awk. See Adapt for tools update godwoken-kicker#345.

  • Removed unused ckb-sdk code.

(For reviewers: review from the second commit, the first one is the same as #940)

@Flouse Flouse requested review from jjyr and zeroqn February 13, 2023 06:17
@blckngm blckngm marked this pull request as ready for review February 20, 2023 05:17
@jjyr
Copy link
Collaborator

jjyr commented Feb 28, 2023

#940 is merged, please rebase this PR

@jjyr jjyr added this pull request to the merge queue Mar 2, 2023
Merged via the queue into godwokenrises:develop with commit 494b1f4 Mar 2, 2023
@blckngm blckngm deleted the deploy-scripts-chaining-1 branch March 14, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants