squidpy -> 1.4.1, anndata -> 0.10.7 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Apr 23, 2024
tools/squidpy/main_macros.xml
Outdated
| <token name="@PROFILE@">20.01</token> | ||
| <token name="@VERSION_SUFFIX@">2</token> | ||
| <token name="@VERSION_SUFFIX@">3</token> |
There was a problem hiding this comment.
this can be reset to 0 if you bump the major version
There was a problem hiding this comment.
sounds good, thanks for looking this over! this is a minor/patch revision bump of squidpy, (1.1.2 -> 1.4.1), is this what you meant? Should I still change the VERSION_SUFFIX to 0, or did you mean change the VERSION_SUFFIX to 1.0?
There was a problem hiding this comment.
@VERSION_SUFFIX@ is meant for the case when you need to update the XML but the @TOOL_VERSION@ does not change. Similar to the build-number in conda.
So whenever you increase @TOOL_VERSION@ you can reset the VERSION_SUFFIX to 0.
make requested `VERSION_SUFFIX` change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping squidpy version to
1.4.1, and dependencyanndatato0.10.7ref: #60