Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dress Rehearsal Testnet "Spadina" v0.12.2 #46

Merged
merged 10 commits into from
Sep 17, 2020
Merged

Dress Rehearsal Testnet "Spadina" v0.12.2 #46

merged 10 commits into from
Sep 17, 2020

Conversation

q9f
Copy link
Member

@q9f q9f commented Sep 11, 2020 •
edited
Loading

Spadina v0.12.2 dress rehearsal testnet (scheduled)

Depends on: ethereum/consensus-specs#2052

@q9f q9f requested a review from djrtwo September 11, 2020 15:06
@q9f q9f self-assigned this Sep 11, 2020
@djrtwo
Copy link
Collaborator

djrtwo commented Sep 11, 2020

I think we should lower MIN_GENESIS_ACTIVE_VALIDATOR_COUNT to something very trivial to ensure that the testnet launches on that tuesday regardless of community engagement. That is, if just a small amount of validators want to have another go at a practice genesis, I don't think it should hold up the event in this case

Suggestion: MIN_GENESIS_ACTIVE_VALIDATOR_COUNT: 1024

@Bzh5579cc
Copy link

那個網站是中國人身份證而用的，我是香港的身分證，老說我的身份認不正確😱

@q9f
Copy link
Member Author

q9f commented Sep 14, 2020

Suggestion: MIN_GENESIS_ACTIVE_VALIDATOR_COUNT: 1024

Done

@hwwhww hwwhww mentioned this pull request Sep 14, 2020
Merged
@ajsutton ajsutton mentioned this pull request Sep 14, 2020
Closed
12 tasks
djrtwo
djrtwo approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Note that we will probably be "officially" at v0.12.3 later this week, but won't affect anything here

@CarlBeek
Copy link

It would be useful to have a different GENESIS_FORK_VERSION to mainnet in this config. While slashings are prevented via genesis_validators_root deposits are not distinct between these two chains, thereby allowing users to deposit with the same keys (and proofs of possession).

In the Launchpad in particular, deposits are identified by the GENESIS_FORK_VERSION and as this PR currently stands, users could end up making the wrong deposit.

@rolfyone
Copy link
Contributor

teku bootnode:
enr:-KG4QAxcrhmEz0t86EcxDpNcPpvNim8m9iG4zEkFxXWUm293cJ9HE_45DgXOcQyImsTt_6EYxpwCKMlGGF1aM037VoIChGV0aDKQ9aX9QgAAAAD__________4JpZIJ2NIJpcIQDFt-UiXNlY3AyNTZrMaECkR4C5DVO_9rB48eHTY4kdyOHsguTEDlvb7Ce0_mvghSDdGNwgiMog3VkcIIjKA

@q9f q9f merged commit 5caf113 into master Sep 17, 2020
@q9f q9f deleted the q9-spadina branch September 17, 2020 13:04
hwwhww added a commit to ethereum/staking-deposit-cli that referenced this pull request Sep 17, 2020
@hwwhww
Update Spadina GENESIS_FORK_VERSION to 0x00000002
728a685 
Sync with goerli/medalla#46 updates
hwwhww added a commit to ethereum/staking-deposit-cli that referenced this pull request Sep 18, 2020
@hwwhww
Add Spadina testnet (#96)
dff423f 
* Add Spadina testnet

* Update Spadina `GENESIS_FORK_VERSION` to `0x00000002`

Sync with goerli/medalla#46 updates
everhusk pushed a commit to earthbitcoin/earth-wallet-cli that referenced this pull request Aug 3, 2023
@hwwhww
Add Spadina testnet (ethereum#96)
83e028c 
* Add Spadina testnet

* Update Spadina `GENESIS_FORK_VERSION` to `0x00000002`

Sync with goerli/medalla#46 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees

@q9f q9f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@q9f @djrtwo @Bzh5579cc @CarlBeek @rolfyone