Ensure validator has the voting snapshot state before sealing #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethcore/src/engines/clique/mod.rs
Outdated
| @@ -396,44 +456,12 @@ impl Engine<EthereumMachine> for Clique { | |||
| header.number(), *self.state.read()); | |||
| */ | |||
|
|
|||
| if self.state(&parent).is_none() { | |||
| return Err(From::from(format!("could not parse parent state for {}", &parent.hash()))); | |||
There was a problem hiding this comment.
the error text here could be more precise:
"Parent state not found or couldn't be recovered."
alternatively, we could also change return value of state() call into an Result<SnapshotState, Error> which may provide better error.
thefallentree
approved these changes
Jan 8, 2019
|
no idea about why CI would fail either, I restarted the job to see if it work this time(TM) |
jwasinger
force-pushed
the
restore-voting-state
branch
from
7796762
to
9fab763
Compare
|
Can you configure your editor for indentation using spaces please? (tab size 2) |
thefallentree
force-pushed
the
restore-voting-state
branch
from
9fab763
to
2aae31b
Compare
|
tested locally without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.