grumble(on_seal_block): make &mut to avoid clone
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
force-pushed
the
block-needless-clone
branch
from
3ee7e8b
to
31f9d75
Compare
niklasad1
force-pushed
the
block-needless-clone
branch
from
31f9d75
to
b27dabb
Compare
soc1c
approved these changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Maybe make
Engine::on_seal_blocktake a&mutof the block instead. This avoids a copy.Originally posted by @sorpaas in https://github.com/paritytech/parity-ethereum/diffs