backports from upstream #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* whisper/cli: add p2p port and ip parameters This is so that those params don't change randomly and are in sync with the URL that is displayed. * feedback: Result instead of panic Co-Authored-By: gballet <gballet@gmail.com> * feedback: Map error in port conversion Co-Authored-By: gballet <gballet@gmail.com> * whisper/cli: User can specify enode private key So that the enode doesn't change at every run. * whipser/cli: finish integrating review feedback. * Accomodate error API change * Update rustc-hex version in whisper/cli/Cargo.toml Co-Authored-By: gballet <gballet@gmail.com> * Update README with new whisper cli options * Fix typo in error message Co-Authored-By: gballet <gballet@gmail.com> * Fix Cargo.lock and build issue after lib version upgrade * Fix another typo Co-Authored-By: gballet <gballet@gmail.com>
* fix(rpc): fix a bunch of clippy lints * fix(rpc clippy): remove unused ignored lints * fix(clippy): fix all redundant_field_names This commit fixes all uses of `redundant_field_names` and removes the ignored lint `redundant_field_names` * fix(brain unwrap): replace with expect
* docs: add changelogs for 2.3.{6,7} and 2.4.{1,2}
* docs: add changelogs for 2.4.3 beta and 2.3.8 stable
* Update docs/CHANGELOG-2.3.md
Co-Authored-By: soc1c <47772477+soc1c@users.noreply.github.com>
* Update docs/CHANGELOG-2.3.md
Co-Authored-By: soc1c <47772477+soc1c@users.noreply.github.com>
* docs: remove empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.