forked from schmittjoh/serializer
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializer refactoring #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to make sure something is formatted as a list, i.e. ``[1, 2, 3]`` in JSON, make sure to add an explicit type like ``@Type("array<integer>")``. closes schmittjoh#571 closes schmittjoh#572 closes schmittjoh#488 closes schmittjoh#304 ...and probably more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently implemented (currently the existing test suite has been fixed and is still green):
Ideas (to do? ):
code styledonePhpCollection and phpoptiondonemake native types handled with listenersdone (this creates 20-30 % of performance penality)and make them treated in the same way as objectsdoneremove handle callback featuredonegraph navigator factorydonesplitted graph navigator into serialize navigator and unserialize navigatordoneconverted type array into value objectdoneperformance benchmark, this version is 20% slower 😢