Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Execute go mod tidy after basic creation #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🚸 Execute go mod tidy after basic creation #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,18 @@ func createBasic(projectPath, modName string) (err error) {
return
}

return runCmd(execCommand("go", "mod", "init", modName))
if err = runCmd(execCommand("go", "mod", "init", modName)); err != nil{
return
}

//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
if err = runCmd(installModules); err != nil{
return
}
Comment on lines +85 to +90
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix directory path construction

The directory path construction adds an extra separator character. The projectPath already contains the full path to the project.

Simplify the directory path assignment:

- installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
+ installModules.Dir = projectPath
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = fmt.Sprintf("%s%c", projectPath, os.PathSeparator)
if err = runCmd(installModules); err != nil{
return
}
//Execute go mod tidy in the project directory
installModules := execCommand("go", "mod", "tidy")
installModules.Dir = projectPath
if err = runCmd(installModules); err != nil{
return
}


return
}

const githubPrefix = "https://github.com/"
Expand Down
Loading