🐛 [Bug]: v3 ctx.Context() is cancelled upon creation

[gistart]

Bug Description

Running app normally w/ Listen -- context is fine, so I can use it for my db queries.

fmt.Printf("%+v // %+v\n", c.Context(), c.Context().Err())
// #0000000100000001 - 127.0.0.1:8081<->127.0.0.1:48162 - GET http://0.0.0.0:8081/test // <nil>

Running a test on the same app -- and context is cancelled upon creation

fmt.Printf("%+v // %+v\n", c.Context(), c.Context().Err())
// #0000000100000001 - 0.0.0.0:0<->0.0.0.0:0 - GET http://example.com/test // context canceled

How to Reproduce

1. Create new app
2. Create any handler
3. Print context and it's Err()

See code snippet below

Expected Behavior

Context in both prod and test should be initialized as not Done, w/o any errors.

Fiber Version

v3.0.0-beta.3

Code Snippet (optional)

// main.go

package main

import (
	"fmt"

	"github.com/gofiber/fiber/v3"
)

func main() {
	app := newApp()
	app.Listen(":8081")
}

func newApp() *fiber.App {
	app := fiber.New()
	app.Get("/test", func(c fiber.Ctx) error {
		fmt.Printf("%+v // %+v\n", c.Context(), c.Context().Err())
		return c.SendString("ok")
	})
	return app
}

// main_test.go

package main

import (
	"net/http/httptest"
	"testing"
)

func TestMain(t *testing.T) {
	app := newApp()

	req := httptest.NewRequest("GET", "/test", nil)
	_, err := app.Test(req, -1)
	if err != nil {
		t.Fatal(err)
	}
}

Checklist:

• I agree to follow Fiber's Code of Conduct.
• I have checked for existing issues that describe my problem prior to opening this one.
• I understand that improperly formatted bug reports may be closed without explanation.

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[gaby]

@gistart I believe you want to use c.UserContext()

The c.Context() returns the Fasthttp context, not the typical Golang context.

@ReneWerner87 We should rename this functions, it's confusing for Golang devs that are used to using Context()

[gistart]

@gaby oh wow, I didn't realize that I shouldn't use Context()

	// Context returns *fasthttp.RequestCtx that carries a deadline
	// a cancellation signal, and other values across API boundaries.
	Context() *fasthttp.RequestCtx

	// UserContext returns a context implementation that was set by
	// user earlier or returns a non-nil, empty context,if it was not set earlier.
	UserContext() context.Context

I thought it's a good idea to use fiber's context for db queries bcs it might implement all the important logic around user disconnects, request timeouts, graceful shutdowns, etc.

Does UserContext have any of these? If not, could you please share a tip on how to implement it myself?

[ReneWerner87]

@gistart I believe you want to use c.UserContext()

The c.Context() returns the Fasthttp context, not the typical Golang context.

@ReneWerner87 We should rename this functions, it's confusing for Golang devs that are used to using Context()

which name would be better ?

ctx.ReqCtx()
ctx.RequestCtx()
ctx.CoreCtx()
ctx.FastHttpCtx()

[gaby]

@gistart I believe you want to use c.UserContext()
The c.Context() returns the Fasthttp context, not the typical Golang context.
@ReneWerner87 We should rename this functions, it's confusing for Golang devs that are used to using Context()

which name would be better ?

ctx.ReqCtx() ctx.RequestCtx() ctx.CoreCtx() ctx.FastHttpCtx()

Probably ctx.RequestCtx() to keep it consistent with fasthttp.

[gaby]

I will do a PR for this today (renaming).

@gistart I will get back to you on your questions once I read the code a bit more. But I believe that UserContext() is what you want.

With my PR I will rename:

• Context() to RequestCtx()
• UserContext() to Context()