🔥 Add Global ViewLayout #1384
Merged
🔥 Add Global ViewLayout #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you please leave another description in the readme or in the docs repository |
|
@ReneWerner87 Added description on docs: gofiber/docs#179 |
|
thx, mist forgot to mention the first time, can you please add another testcase |
|
@ReneWerner87 It seems need to add most of the functionality for template to be added. Will it be acceptable if I add test template engine similar to html template for test? |
|
use the template test engine as in the other tests |
|
@ReneWerner87 Added test case for Views Layout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
This PR will resolve #1382 by adding
ViewLayoutin fiber.Config allowing users to not define layout everywhereExplain the details for making this change. What existing problem does the pull request solve?
This change allows user pass layout as global config and User don't need to pass layout on each render