Improved some conditions #1386
Merged
Improved some conditions #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 16, 2021 08:52
…start with a capital letter or end with a punctuation mark
…mmended that the error variables that are part of an API should be named
ReneWerner87
approved these changes
Jun 17, 2021
ReneWerner87
added a commit
that referenced
this pull request
Aug 30, 2021
* simplify `u <= (1<<7)-1` to `u < (1 << 7)` * It's not recommended to use `len` for empty string, we can check with string with "" * It's not recommended to use `len` for empty string, we can check with string with "" * It's not recommended to use `len` for empty string, we can check with string with "" * It's not recommended to use `len` for empty string, we can check with string with "" * Instead Bool comparison can using simplified bool check if !var = false checking * Unnecessary use of fmt.Sprintf for value without format * For check condition two value not required ! method * nil check may not be enough for slice, better check with len * function parameters combined * When the form returns error information, the text content should not start with a capital letter or end with a punctuation mark * error var invalidPath should have name of the form errFoo, It is recommended that the error variables that are part of an API should be named * change to condition len(x), it's faster #1386 (comment) * Update write.go * Update write_bytes.go * Update store.go * Adapted paragraph fiber version compatible with go * add translated paragraph net/http interfaces limitation Co-authored-by: RW <rene@gofiber.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.