-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added decompression cases for Body function #1402
✨ Added decompression cases for Body function #1402
Conversation
improve Body function
improve performance
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
I saw this update yesterday when I updated my project....
I think this is no longer true then... This also broken for who doesn't want to deal with the uncompressed data. Anyway, just mentioning a few points that come to my mind. []'s |
Please provide enough information so that others can review your pull request:
According to this issue I created a bit earlier #1401, I have implemented a filter to return the correct body each time the
Body
function of the fiber.Ctx struct is calledExplain the details for making this change. What existing problem does the pull request solve?
Fasthttp provides by default methods for decompressing different request payloads, currently, gofiber directly returns the raw body, if the body is compressed using gzip/deflate/brotli then it gets returned like that and the users has to decompress it manually. This PR fixes this issue
I have also updated the tests accordingly