-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ${port} logger variable #1448
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Could you add a description in the readme and a unittest fpr for this? |
@ReneWerner87 can you check if it's ok now? |
@ReneWerner87 Simplified the code and ran tests locally with |
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
@markkrj can you please update https://github.com/gofiber/docs/blob/master/api/middleware/logger.md with the new variable |
@ReneWerner87 I sure can do that, but I think linking that to https://github.com/gofiber/fiber/blob/master/middleware/logger/README.md is a better solution as it is more up to date... There is more changes to logger that are not documented in gofiber/docs. IMHO you should keep docs only in one place to avoid such discrepancy. |
yes gladly if git docs can work with it and does not produce a linkout when you click on it in the navigation all is good |
just tested it, in the gitbook would then show an external link, so we have to copy it |
Fix #1447
port
variable to middleware/logger