📝 Update: Add JSONDecoder to config

[pd-pranay]

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?
Add json decoder to config

This pull request is in reference to #1452
Commit formatting

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

[pd-pranay]

Let me know if everything is fine.

[ReneWerner87]

Could you please add a test for the configuration possibility and a part in the docs repository.

[pd-pranay]

Could you please add a test for the configuration possibility and a part in the docs repository.

Sure 👍

[ReneWerner87]

See the possibility to define the decoder, but no use within the framework/library, then shouldn't we use somewhere the method which was configured?

[pd-pranay]

See the possibility to define the decoder, but no use within the framework/library, then shouldn't we use somewhere the method which was configured?

Yes, I was thinking to add this to methods in ctx.go with using app.config's Encoder and Decoder.
Will this do the work ? @ReneWerner87

func (c *Ctx)JSONDecoder(raw []byte, data interface{}) error {
	err := c.app.config.JSONDecoder(raw, data)
	if err != nil {
		return err
	}
	return nil
}

func (c *Ctx)JSONEncoder(data interface{}) ([]byte, error) {
	raw, err := c.app.config.JSONEncoder(data)
	if err != nil {
		return nil, err
	}
	return raw, nil
}

[ReneWerner87]

thought rather that the decoder should be used in the bodyParser or everywhere where we directly use the json unmarshal

i wouldn't provide an extra method in the context because it doesn't really have any reference to it and the one who sets the decoders and encoders from the outside in the config can use them from the outside capsule too

the only benefit i can think of is that you exchange the internal usages

[ReneWerner87]

@pd-pranay could you change all the usages for the unmarshall method

[pd-pranay]

@ReneWerner87 can you help me with references where I should be changing usages of unmarshal method ?
I found one is this correct one ?
https://github.com/gofiber/fiber/blob/master/ctx.go#L294

[ReneWerner87]

@pd-pranay Yes, that should be the only

[pd-pranay]

For docs what type should I define JSONDecoder ?

[ReneWerner87]

https://docs.gofiber.io/api/fiber#config

it should just show up here so users know they can customize it, maybe you can add the doc for JSONEncode as well

[ReneWerner87]

https://docs.gofiber.io/api/fiber#config

it should just show up here so users know they can customize it, maybe you can add the doc for JSONEncode as well

@pd-pranay can you add JSONEncode and JSONDecode to the documentation ?
https://github.com/gofiber/docs/blob/master/api/fiber.md#config