-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ v3 (feature): new Route method #2065
Conversation
@wangjq4214 Why you changed |
I think the method returned by this function is probably more commonly used, so a simpler name is needed. Changing the previous name is not quite right, I will change it back, do you have any idea about the name of this type? |
@wangjq4214 We can use Router interface for this method |
Router interface is not compatible for this stuff. It has path param in methods |
That's true. You are right. |
I think we should change Route struct name |
Maybe we can add interface named |
Actually |
@wangjq4214 thx for the PR can you create some test with route which have a deeper level so for example 3 level so we can be sure that there can be scaled infinitely |
@efectn thx |
related to #1829