Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ v3 (feature): new Route method #2065

Merged
merged 9 commits into from
Sep 18, 2022

Conversation

wangjq4214
Copy link
Member

related to #1829

@efectn efectn added this to the v3 milestone Aug 30, 2022
@efectn efectn changed the title Feat new route ✨ v3 (feature): new Route method Aug 30, 2022
@balcieren
Copy link
Contributor

balcieren commented Aug 30, 2022

@wangjq4214 Why you changed Route with RouteInfo ?

@wangjq4214
Copy link
Member Author

@wangjq4214 Why you changed Route with RouteInfo ?

I think the method returned by this function is probably more commonly used, so a simpler name is needed. Changing the previous name is not quite right, I will change it back, do you have any idea about the name of this type?

@wangjq4214 wangjq4214 marked this pull request as ready for review August 31, 2022 14:10
register.go Outdated Show resolved Hide resolved
register.go Show resolved Hide resolved
@balcieren
Copy link
Contributor

@wangjq4214 We can use Router interface for this method

@efectn
Copy link
Member

efectn commented Aug 31, 2022

Router interface is not compatible for this stuff. It has path param in methods

@balcieren
Copy link
Contributor

Router interface is not compatible for this stuff. It has path param in methods

That's true. You are right.

@balcieren
Copy link
Contributor

I think we should change Route struct name

@efectn
Copy link
Member

efectn commented Sep 1, 2022

Maybe we can add interface named RegisterI or something else and return it instead of *Register. Wdym @wangjq4214

@balcieren
Copy link
Contributor

balcieren commented Sep 2, 2022

Actually RouteFunc might be a good name to seperate from Route

@ReneWerner87
Copy link
Member

@wangjq4214 thx for the PR

can you create some test with route which have a deeper level

so for example 3 level

so we can be sure that there can be scaled infinitely

@wangjq4214
Copy link
Member Author

@efectn thx

@ReneWerner87 ReneWerner87 merged commit 093882c into gofiber:v3-beta Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants