Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: fix logger benchmarks #2074

Merged
merged 4 commits into from
Sep 6, 2022
Merged

v3: fix logger benchmarks #2074

merged 4 commits into from
Sep 6, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Sep 6, 2022

  • Don't create mutex in each request.
  • Use pointer to define LoggerData. Otherwise, we always copy it

@efectn efectn added this to the v3 milestone Sep 6, 2022
@ReneWerner87 ReneWerner87 merged commit e9db6c7 into v3-beta Sep 6, 2022
@efectn efectn deleted the v3-fix-logger-benchmark branch September 6, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

Assignees
No one assigned
Labels
☢️ Bug v3
Projects
v3
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@efectn @ReneWerner87