Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctx: change signatures of GetReqHeaders and GetRespHeaders #2650

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

efectn
Copy link
Member

@efectn efectn commented Sep 27, 2023

Description

Fixes #2594

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

ctx.go Outdated Show resolved Hide resolved
@ReneWerner87 ReneWerner87 merged commit a9447a5 into master Sep 28, 2023
20 checks passed
@efectn efectn deleted the getreqheader-signature branch September 28, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Ctx.GetReqHeaders doesn't respect multiple fields with same name
3 participants