Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Bug]: Naming of routes works wrong after mount #2688 #2689

Merged
merged 1 commit into from
Oct 23, 2023
Merged

🐛 [Bug]: Naming of routes works wrong after mount #2688 #2689

merged 1 commit into from
Oct 23, 2023

Conversation

ReneWerner87
Copy link
Member

Description

Fixes #2688

Enables the use of routes with names after apps have been mounted

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible

@ReneWerner87 ReneWerner87 merged commit db62f9c into master Oct 23, 2023
21 checks passed
@efectn efectn deleted the fix-route-naming-subapps branch October 23, 2023 12:10
@ReneWerner87 ReneWerner87 added this to the v2 Next Release milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efectn efectn efectn approved these changes

@Antonov-guap Antonov-guap Antonov-guap approved these changes

Assignees
No one assigned
Labels
☢️ Bug
Projects
None yet
Milestone
v2.51.0
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Naming of routes works wrong after mount
3 participants
@ReneWerner87 @Antonov-guap @efectn