📚 Doc: Add additional information as to why GetReqHeaders returns a map where the values are slices of strings #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional information to why GetReqHeaders returns a map where the values are slices of strings (instead of a single string as one might expect)
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
efectn
reviewed
Nov 1, 2023
added the same explanation to GetRespHeaders too
|
sure, done |
ReneWerner87
approved these changes
Nov 1, 2023
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional information as to why GetReqHeaders returns a map where the values are slices of strings (instead of a single string as one might expect)
Description
In a (more or less) recent breaking change, the signature of GetReqHeaders was changed to return a map where the values are not single strings anymore but instead slices of strings. As someone who encountered this breaking change after upgrading fiber, it was not clear why this was changed and - more importantly - what exactly would be contained in these slices. Therefore I added a short and simple explanation what one can expect to be returned by this method.
Documents the intent of #2594
Type of change
Please delete options that are not relevant.