Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cors.md documentation #2881

Closed
wants to merge 1 commit into from
Closed

Update cors.md documentation #2881

wants to merge 1 commit into from

Conversation

brunobmello25
Copy link

Description

Recent version of golang fiber now breaks if you provide allowOrigins configuration with a space after the comma. For example, if you give the input:

https://first-url.com, https://second-url.com

it breaks with the following error:

2024/02/26 15:01:16.338384 cors.go:124: [Warn] [CORS] Invalid origin format in configuration: https://second-url.com


## Changes Introduced

- Update docs for `docs/api/middleware/cors.md`

- [x] Documentation update (changes to documentation)

Copy link

welcome bot commented Feb 26, 2024

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Member

@sixcolors sixcolors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug to me.

will confirm shortly.

@sixcolors
Copy link
Member

superseeded by #2883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants