Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Improve csrf middleware #959

Merged
merged 1 commit into from
Oct 25, 2020
Merged

👷 Improve csrf middleware #959

merged 1 commit into from
Oct 25, 2020

Conversation

kiyonlin
Copy link
Contributor

Please provide enough information so that others can review your pull request:

  • Skip non GET/POST http method
  • Delete token if matched
  • Use cfg.Expiration instead of cfg.CookieExpires

Explain the details for making this change. What existing problem does the pull request solve?

@kiyonlin
👷 Improve csrf middleware
5ea5bbf 
- Skip non GET/POST http method
- Delete token if matched
- Use cfg.Expiration instead of cfg.CookieExpires
@kiyonlin kiyonlin requested a review from a team as a code owner October 24, 2020 02:20
@kiyonlin kiyonlin requested review from ReneWerner87 and Fenny and removed request for a team October 24, 2020 02:20
@Fenny Fenny merged commit e619451 into gofiber:master Oct 25, 2020
@kiyonlin kiyonlin deleted the improve-csrf branch October 27, 2020 04:15
@renovate renovate bot mentioned this pull request Jun 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 Awaiting requested review from ReneWerner87

@Fenny Fenny Awaiting requested review from Fenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiyonlin @Fenny