Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Add missing header and compression result assertion in different compression levels test #962

Merged
merged 1 commit into from
Oct 25, 2020
Merged

🚨 Add missing header and compression result assertion in different compression levels test #962

merged 1 commit into from
Oct 25, 2020

Conversation

sbielenica
Copy link
Contributor

@sbielenica sbielenica commented Oct 25, 2020

Adjusted one of the compression tests. Previously it didn't compress results at all. It just checked if 200 is returned without verifying compression results.

@sbielenica sbielenica requested a review from a team as a code owner October 25, 2020 11:05
@sbielenica sbielenica requested review from ReneWerner87 and Fenny and removed request for a team October 25, 2020 11:05
@welcome
Copy link

welcome bot commented Oct 25, 2020

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Contributor

@kiyonlin kiyonlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement

@Fenny Fenny merged commit 4dd33f1 into gofiber:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants