Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #966

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Update README.md #966

merged 1 commit into from
Oct 27, 2020

Conversation

G2G2G2G
Copy link
Contributor

@G2G2G2G G2G2G2G commented Oct 26, 2020

this error happens without the comma:

./fiber.go:15:18: syntax error: unexpected newline, expecting comma or }

@G2G2G2G G2G2G2G requested a review from a team as a code owner October 26, 2020 02:52
@G2G2G2G G2G2G2G requested review from jozsefsallai and Fenny and removed request for a team October 26, 2020 02:52
@welcome
Copy link

welcome bot commented Oct 26, 2020

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@Fenny
Copy link
Member

Fenny commented Oct 26, 2020

Nice catch, by any chance you could also fix the other README's (languages)?

@G2G2G2G
Copy link
Contributor Author

G2G2G2G commented Oct 26, 2020

I don't know how to get to other languages, I also updated the "fiber/docs" area though

@renanbastos93
Copy link
Member

Nice catch, by any chance you could also fix the other README's (languages)?

Which others readme file to change? He changes only the middleware readme file. seems right to me.

@G2G2G2G
Copy link
Contributor Author

G2G2G2G commented Oct 26, 2020

gofiber/docs#134
This is the only other one I found (well I found the above one first actually) then searched for it again and found the readme.md I edited here.
If any others exist I don't know how to get to them, I edit through github and use google syntax to search for it though so it's pretty bad LOL
(also anyone is welcome to reject my pull request & change the file themselves, my githubs are usually throwaway accounts)

@Fenny
Copy link
Member

Fenny commented Oct 27, 2020

@G2G2G2G my bad, I miss-read the filename 😭 I thought it was the original README.md, sorry!

@Fenny Fenny merged commit 3dd3a0e into gofiber:master Oct 27, 2020
@welcome
Copy link

welcome bot commented Oct 27, 2020

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants