Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Update dependabot configuration #77

Merged
merged 8 commits into from
Oct 10, 2022
Merged

Update dependabot configuration #77

merged 8 commits into from
Oct 10, 2022

Conversation

gaby
Copy link
Member

@gaby gaby commented Oct 9, 2022

  • Added support for tracking updates for Github-Actions via dependabot
  • Added support for auto-merging dependabot PR's

@gaby gaby requested review from ReneWerner87 and efectn October 9, 2022 18:29
@efectn
Copy link
Member

efectn commented Oct 9, 2022

Can you check the indention

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

Can you check the indention

For some reason it doesnt like those keys, even though I copy them from another fiber repo. Let me check again...

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

So, it turns out that automerged was disable by Github. The reason it works in other Fiber repos is because they are not using the dependabot validator (Ex: boilerolate repo).

More info here: dependabot/dependabot-core#1973

The recommended way to auto merge now is via Github Actions as Fiber does in several repos.

@efectn
Copy link
Member

efectn commented Oct 9, 2022

I think we can add automerge action to this repo

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

I think we can add automerge action to this repo

Ok, let me add the file to this sams PR then.

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

Repo needs a secret/token for wait_for to work properly.

@efectn
Copy link
Member

efectn commented Oct 9, 2022

Repo needs a secret/token for wait_for to work properly.

@ReneWerner87 can you check it

@ReneWerner87
Copy link
Member

Sure

@ReneWerner87
Copy link
Member

I think I still have to activate the token for the repository
also the regex for the wait check has to be changed, because the job name is "Test" and not "Tests".
Or the job must be renamed

I will do it tomorrow

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

I think I still have to activate the token for the repository also the regex for the wait check has to be changed, because the job name is "Test" and not "Tests". Or the job must be renamed

I will do it tomorrow

Thanks! I just updated the job name to Tests.

@ReneWerner87
Copy link
Member

@gaby
Copy link
Member Author

gaby commented Oct 9, 2022

https://github.com/gofiber/keyauth/blob/master/.github/workflows/test.yml#L4 Is also wrong

Updated, also added more Go versions to matrix. Seems like this middleware needs some unit-testing byt that should be cover by a different PR.

@ReneWerner87 ReneWerner87 merged commit d69a5e1 into master Oct 10, 2022
@gaby gaby deleted the dependabot branch October 10, 2022 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants