New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Parallel Benchmarks for Mustache Engine #346

Merged

ReneWerner87 merged 2 commits into master from missing-bench

Feb 22, 2024

Member

gaby commented Feb 22, 2024 •

edited

Loading

Add missing parallel benchmarks for Mustache
Fix the names of all the benchmarks. Before the change they had the word "parallel" twice in the name.
Added missing key/value from Benchmark workflow based on official docs: https://github.com/benchmark-action/github-action-benchmark#minimal-setup Basically we were never storing results and comparing with previous run.


          Add missing paralle mustache benchmarks. Fix names of all benchmarks

e06fde7

gaby requested review from a team, sixcolors, ReneWerner87 and efectn and removed request for a team

February 22, 2024 04:04

gaby added the 🧹 Updates label


          Fix benchmarks workflow

ReneWerner87 approved these changes

View reviewed changes

ReneWerner87 merged commit 0b4ca55 into master

111 checks passed

gaby deleted the missing-bench branch

February 22, 2024 12:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ReneWerner87 ReneWerner87 approved these changes

sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

efectn Awaiting requested review from efectn efectn is a code owner automatically assigned from gofiber/maintainers

Labels