This repository has been archived by the owner on May 24, 2023. It is now read-only.
adding work with headers #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested this customization in a real application with websocket connection? Not sure about the headers Can you please add another test for this new unit |
|
Yes, I tested this function in the working application and it showed a positive result, but so far I had to use this fork https://github.com/ibuymovie/websocket I won't be able to submit the test now, since there is not a single test for an example to this library. |
|
Ok, i will try to add these tests at the weekend |
ReneWerner87
approved these changes
May 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I do not really understand why this opportunity was not available before, I would like to know if this change is possible.