Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front end bug fixes #674

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Front end bug fixes #674

merged 3 commits into from
Mar 21, 2022

Conversation

brandonfancher
Copy link
Collaborator

@brandonfancher brandonfancher commented Mar 21, 2022 •
edited
Loading

This PR fixes the following issues:

  • If user signs in as a non-member EOS account, they cannot sign out without clearing local storage. This was a regression introduced in a prior refactor.
  • A member's NFT collection was not displaying; it was trying to fetch more items than allowed by the AtomicMarket API (a limit which they randomly began enforcing). We fixed this previously for a member's list of collectORS, but not for their collectION.
  • Console was complaining that a React component key was missing from a component on the Treasury page.

Note: Each commit maps 1:1 with a bug above, so it's likely easiest to review this commit-by-commit.

@brandonfancher brandonfancher requested a review from cool-ant March 21, 2022 19:14
GreenBusDriver
GreenBusDriver approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@GreenBusDriver GreenBusDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just the e2e tests seem to be failing. I assume you're looking at that as I type

@brandonfancher brandonfancher temporarily deployed to e2e_tests March 21, 2022 20:27 Inactive
@brandonfancher brandonfancher merged commit acc9843 into main Mar 21, 2022
@brandonfancher brandonfancher deleted the brandon/cumulative-fixes branch March 21, 2022 20:41
@brandonfancher brandonfancher mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cool-ant cool-ant cool-ant approved these changes

@GreenBusDriver GreenBusDriver GreenBusDriver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonfancher @GreenBusDriver @cool-ant