Covered UUID.decodePlain() with wrong input with a test #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerkms I just destroyed your branch, I'm sorry. :( |
|
It's fine, I need to include a tiny change there anyway :-) |
zerkms
force-pushed
the
CODEC_AND_SQL_CODE_COVERAGE
branch
from
91b8200
to
36ec376
Compare
zerkms
changed the title
theckman
reviewed
Jul 17, 2018
codec_test.go
Outdated
| arg := []byte{'4', '2'} | ||
|
|
||
| u := UUID{} | ||
| err := u.decodePlain(arg) |
There was a problem hiding this comment.
@zerkms I might be nitpicking here a bit. Since we do not use the error value, how do we feel about simplifying this to the single if expression?
if u.decodePlain(arg) == nil {}There was a problem hiding this comment.
The alternative I'd go with, if we care about the error type, would be:
var err error
// ...
if err = u.decodePlain(arg); err == nil {}Just so that we assert the return type as being an error value.
There was a problem hiding this comment.
I don't mind in either, but would personally prefer the first (given every other test case does not care about the exact returned err type either).
zerkms
force-pushed
the
CODEC_AND_SQL_CODE_COVERAGE
branch
from
36ec376
to
774487f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestDecodePlainWithWrongLengthruns unexported method since there is no other way to reach that line.It's a substitution for the #22 which I accidentally closed via deleting my branch (instead of hard-push'ing it)