Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend that people use v2.0.0+ in the README #30

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Recommend that people use v2.0.0+ in the README #30

merged 1 commit into from
Jul 18, 2018

Conversation

theckman
Copy link
Member

Anything less than v2.0.0 is known to have some deficiencies, so this updates
the README to recommend consumers use 2.0.0+.

v2.0.0 needs to be released after merging this change.

Signed-off-by: Tim Heckman t@heckman.io

@theckman theckman added this to the 2.0.0 milestone Jul 18, 2018
@theckman theckman self-assigned this Jul 18, 2018
@theckman
Copy link
Member Author

Pending any requested changes to this PR, or additional features, the tentative plan is to merge this PR in the morning (~8-10 hours from now) and cut the v2.0.0 release on the merge commit.

@theckman theckman mentioned this pull request Jul 18, 2018
@coveralls
Copy link

coveralls commented Jul 18, 2018

Pull Request Test Coverage Report for Build 89

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 98.214%

Totals Coverage Status
Change from base Build 85: -0.8%
Covered Lines: 165
Relevant Lines: 168

💛 - Coveralls

Anything less than v2.0.0 is known to have some deficiencies, so this updates
the README to recommend consumers use 2.0.0+.

v2.0.0 needs to be released after merging this change.

Signed-off-by: Tim Heckman <t@heckman.io>
Copy link
Member

@acln0 acln0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theckman theckman merged commit 489d38f into master Jul 18, 2018
theckman added a commit that referenced this pull request Jul 18, 2018
Recommend that people use v2.0.0+ in the README

Signed-off-by: Tim Heckman <t@heckman.io>
@theckman theckman deleted the v2.0.0 branch July 18, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants