Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fuzz test for FromString #5

Merged
merged 1 commit into from
Jul 13, 2018
Merged

add fuzz test for FromString #5

merged 1 commit into from
Jul 13, 2018

Conversation

acln0
Copy link
Member

@acln0 acln0 commented Jul 13, 2018

Fuzz FromString using github.com/dvyukov/go-fuzz. FromString calls
(*UUID).UnmarshalText, so this test touches all of the places where
package uuid might parse interesting user input.

Since the initial encoding of the UUID is lost when parsed, we cannot
do any better than a simple valid/invalid test.

Updates #2.

Fuzz FromString using github.com/dvyukov/go-fuzz. FromString calls
(*UUID).UnmarshalText, so this test touches all of the places where
package uuid might parse interesting user input.

Since the initial encoding of the UUID is lost when parsed, we cannot
do any better than a simple valid/invalid test.

Updates #2.
@niaow
Copy link
Member

niaow commented Jul 13, 2018

note: CI failures will be fixed by #4

Copy link
Member

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acln0 To confirm, we're intending on attacking the TODO at a later time?

@acln0
Copy link
Member Author

acln0 commented Jul 13, 2018

@theckman Yes. I wanted to just get this in for now. Once we figure out the answer to the question of where to store the testing corpus (if at all) in #2, I'd like to discuss how to seed the corpus with inputs we're already using for testing.

@theckman theckman closed this Jul 13, 2018
@theckman theckman reopened this Jul 13, 2018
@theckman theckman merged commit 8acd3e7 into gofrs:master Jul 13, 2018
theckman added a commit that referenced this pull request Jul 13, 2018
add fuzz test for FromString

Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants