Revive travis #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
requested changes
Jul 13, 2018
There was a problem hiding this comment.
Thank you for your contribution. Before merging would you be able to make some changes to this branch? Specifically, I'd prefer that each change in this branch be squashed in to a single commit. While doing that, would you be able to ensure the commit contains context behind the change being made.
I like to use this post as inspiration for my commits:
This was referenced Jul 13, 2018
|
Ok i will squash them in a bit |
|
It has been squashed. This can be merged once the CI runs. |
theckman
approved these changes
Jul 13, 2018
theckman
added a commit
that referenced
this pull request
Jul 13, 2018
Revive travis Signed-off-by: Tim Heckman <theckman@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 by updating go and ditching go 1.2