Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SSL #51 #53

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Added support for SSL #51 #53

merged 4 commits into from
Jun 24, 2020

Conversation

muhammednagy
Copy link
Member

Fixes #51 .

Changes proposed in this pull request:

  • Added support for TLS/SSL

@muhammednagy muhammednagy added the enhancement New feature or request label Jun 24, 2020
abdallahokasha
abdallahokasha previously approved these changes Jun 24, 2020
View reviewed changes
@abahmed
Copy link
Member

abahmed commented Jun 24, 2020

@muhammednagy check (https://deepsource.io/gh/gogearbox/gearbox/run/916455a3-9608-4195-b392-2354fd9e01be/go/)

@muhammednagy muhammednagy added enhancement New feature or request and removed enhancement New feature or request labels Jun 24, 2020
@muhammednagy muhammednagy added enhancement New feature or request and removed enhancement New feature or request labels Jun 24, 2020
abdallahokasha
abdallahokasha previously approved these changes Jun 24, 2020
View reviewed changes
abahmed
abahmed previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammednagy Great Job! :-)

@muhammednagy muhammednagy dismissed stale reviews from abahmed and abdallahokasha via 4e1bf12 June 24, 2020 22:13
@abahmed abahmed added the chore Improvements without changing the functionality label Jun 24, 2020
@muhammednagy muhammednagy merged commit 2213f9c into master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abahmed abahmed abahmed approved these changes

@abdallahokasha abdallahokasha abdallahokasha left review comments

Assignees

@abahmed abahmed

Labels
chore Improvements without changing the functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL support.
3 participants
@muhammednagy @abahmed @abdallahokasha