Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #86 slicing empty path in matchRoute #88

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fixes #86 slicing empty path in matchRoute #88

merged 1 commit into from
Apr 18, 2021

Conversation

abahmed
Copy link
Member

@abahmed abahmed commented Apr 18, 2021

Fixes #86

Changes proposed in this pull request:

  • fixes slicing empty path in matchRoute

@auto-assign auto-assign bot requested a review from muhammednagy April 18, 2021 22:26
@abahmed abahmed added bug Something isn't working chore Improvements without changing the functionality fix and removed bug Something isn't working chore Improvements without changing the functionality labels Apr 18, 2021
@abahmed abahmed added bug Something isn't working and removed bug Something isn't working fix labels Apr 18, 2021
@abahmed abahmed merged commit 812e8fb into master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew44Ashraf Andrew44Ashraf Andrew44Ashraf approved these changes

@muhammednagy muhammednagy Awaiting requested review from muhammednagy

Assignees

@muhammednagy muhammednagy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: slice bounds out of range [1:0]
3 participants
@abahmed @Andrew44Ashraf @muhammednagy