fix issue #2331

gogf · Feb 8, 2023 · 83fb3ae · 83fb3ae
1 parent 21ebf48
commit 83fb3ae
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/contrib/nosql/redis/redis_z_unit_gcache_adapter_test.go b/contrib/nosql/redis/redis_z_unit_gcache_adapter_test.go
@@ -246,7 +246,7 @@ func Test_AdapterRedis_SetIfNotExistFunc(t *testing.T) {
 			return 11, nil
 		}, 0)
 		t.AssertNil(err)
-		t.Assert(exist, false)
+		t.Assert(exist, true)
 	})
 }
 
@@ -257,7 +257,7 @@ func Test_AdapterRedis_SetIfNotExistFuncLock(t *testing.T) {
 			return 11, nil
 		}, 0)
 		t.AssertNil(err)
-		t.Assert(exist, false)
+		t.Assert(exist, true)
 	})
 }
 

diff --git a/os/gcache/gcache_adapter_redis.go b/os/gcache/gcache_adapter_redis.go
@@ -121,17 +121,17 @@ func (c *AdapterRedis) SetIfNotExist(ctx context.Context, key interface{}, value
 	}
 	ok, err = c.redis.SetNX(ctx, redisKey, value)
 	if err != nil {
-		return false, err
+		return ok, err
 	}
 	if ok && duration > 0 {
 		// Set the expiration.
 		_, err = c.redis.Expire(ctx, redisKey, int64(duration.Seconds()))
 		if err != nil {
-			return false, err
+			return ok, err
 		}
-		return true, err
+		return ok, err
 	}
-	return false, err
+	return ok, err
 }
 
 // SetIfNotExistFunc sets `key` with result of function `f` and returns true