Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a comment error in IsSubDomain #1509

Merged
merged 1 commit into from
Dec 5, 2021
Merged

fix a comment error in IsSubDomain #1509

merged 1 commit into from
Dec 5, 2021

Conversation

victory460
Copy link
Contributor

Why is this pull request needed and what does it do?

Fix a comment error in IsSubDomain.

Signed-off-by: xuweiwei <xuweiwei_yewu@cmss.chinamobile.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1509 (f56c2ed) into master (80e8a58) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
+ Coverage   71.21%   71.24%   +0.02%     
==========================================
  Files         415      415              
  Lines       40413    40413              
==========================================
+ Hits        28780    28791      +11     
+ Misses       9811     9801      -10     
+ Partials     1822     1821       -1     
Flag Coverage Δ
go-1.14 71.19% <100.00%> (-0.02%) ⬇️
go-1.15 71.19% <100.00%> (-0.01%) ⬇️
go-1.16 71.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
text/gstr/gstr_domain.go 100.00% <100.00%> (ø)
os/gspath/gspath_cache.go 91.22% <0.00%> (-3.51%) ⬇️
net/gtcp/gtcp_conn.go 34.05% <0.00%> (+2.16%) ⬆️
net/gtcp/gtcp_pool.go 38.63% <0.00%> (+10.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e8a58...f56c2ed. Read the comment docs.

@gqcn gqcn merged commit d330e9a into gogf:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants