Validator Function Example #1510
Merged
+1,488
−1,229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.New 2.Run 3.Clone 4.I18n
1.Ci 2.Data 3.Assoc 4.Rules 5.Messages
1.RuleFunc 2.RuleFuncMap
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 70.65% 70.66% +0.01%
==========================================
Files 425 425
Lines 41123 41123
==========================================
+ Hits 29054 29060 +6
+ Misses 10218 10215 -3
+ Partials 1851 1848 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gqcn
requested changes
Dec 4, 2021
|
|
||
| // Output: | ||
| // The Name field is required | ||
| } |
There was a problem hiding this comment.
虽然是Rule方法的示例代码，但是里面缺没有用到Rule方法，我的建议是规则Example和方法Example分开，方法Example就只是简单的一个使用示例代码即可。
其他方法也是如此。
# Conflicts: # util/gvalid/gvalid_z_example_test.go
gqcn
requested changes
Dec 5, 2021
util/gvalid/gvalid_z_example_test.go
Outdated
| } | ||
|
|
||
| // Output: | ||
| // The Name field is required | ||
| } | ||
|
|
||
| func ExampleValidator_RequiredIf() { | ||
| func ExampleValidator_Rule_RequiredIf() { |
There was a problem hiding this comment.
如果将所有的规则示例代码都绑定到Rule方法中，IDE的代码提示会不会很不友好？
util/gvalid/gvalid_z_example_test.go
Outdated
| @@ -1367,3 +1110,246 @@ func ExampleValidator_Regex() { | |||
| // The Regex1 value `1234` must be in regex of: [1-9][0-9]{4,14} | |||
| // The Regex2 value `01234` must be in regex of: [1-9][0-9]{4,14} | |||
| } | |||
|
|
|||
| func ExampleCheckMap() { | |||
util/gvalid/gvalid_z_example_test.go
Outdated
| // 账号不能为空 | ||
| } | ||
|
|
||
| func ExampleCheckMap2() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| } | ||
|
|
||
| // Empty string attribute. | ||
| func ExampleCheckStruct() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| } | ||
|
|
||
| // Empty pointer attribute. | ||
| func ExampleCheckStruct2() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| } | ||
|
|
||
| // Empty integer attribute. | ||
| func ExampleCheckStruct3() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| // <nil> | ||
| } | ||
|
|
||
| func ExampleValidator_CheckValue() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| // 未成年人不允许注册哟 | ||
| } | ||
|
|
||
| func ExampleValidator_CheckMap() { |
util/gvalid/gvalid_z_example_test.go
Outdated
| // } | ||
| } | ||
|
|
||
| func ExampleValidator_CheckStruct() { |
gqcn
requested changes
Dec 6, 2021
gqcn
requested changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.